Skip to content

gh-145376: Fix various reference leaks objects and modules#145385

Open
eendebakpt wants to merge 5 commits intopython:mainfrom
eendebakpt:refleaks
Open

gh-145376: Fix various reference leaks objects and modules#145385
eendebakpt wants to merge 5 commits intopython:mainfrom
eendebakpt:refleaks

Conversation

@eendebakpt
Copy link
Contributor

@eendebakpt eendebakpt commented Mar 1, 2026

@eendebakpt eendebakpt marked this pull request as ready for review March 1, 2026 10:28
@StanFromIreland
Copy link
Member

Is this going to be a competition between Claude and Codex now 😆?

@eendebakpt
Copy link
Contributor Author

eendebakpt commented Mar 1, 2026

Is this going to be a competition between Claude and Codex now 😆?

As long as the competition is on quality and not quantity we should be fine :-)

Update: I checked import.c which was changed in the PR by @JelleZijlstra. Claude found 4 (potential) issues, including the one in the other PR.

@eendebakpt eendebakpt changed the title gh-145376: Fix various reference leaks gh-145376: Fix various reference leaks objects and modules Mar 1, 2026
@encukou
Copy link
Member

encukou commented Mar 3, 2026

It defintely shouldn't be on quantity of PRs. Could you combine these rather than send several PRs at once?

@eendebakpt
Copy link
Contributor Author

It defintely shouldn't be on quantity of PRs. Could you combine these rather than send several PRs at once?

I know some other core devs strongly prefer to keep PRs small and isolated. For that reason I created more PRs targeting only a single module at a time. To give an idea: analyzing the Modules folder resulted in 60 potential bugs in 30 files. I estimate that about 20 of them are false positives, or tricky cases. With more prompting to the LLM additional potential issues might be found.

Let me know how you would like to group the remaining cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants